Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32476][runtime] Support configuring object-reuse for internal operators #22897

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sxnan
Copy link
Contributor

@Sxnan Sxnan commented Jun 29, 2023

What is the purpose of the change

This PR allows the internal operators to report whether the operators will modify the input so that Flink can decide whether to enable object-reuse for the operators.

Brief change log

  • Add an internal method to StreamOperator to allow implementations to report whether the operator will modify the input.
  • Update the internal SQL and DataStream operators to overwrite the method accordingly.

Verifying this change

This change added tests and can be verified as follows:

  • Add tests that validate the object reuse behavior in StreamOperatorChainingTest.java.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@Sxnan Sxnan marked this pull request as ready for review June 29, 2023 03:10
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 29, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Sxnan Sxnan force-pushed the object-reuse branch 2 times, most recently from 0603110 to 77d7968 Compare September 25, 2023 09:46
@Sxnan
Copy link
Contributor Author

Sxnan commented Sep 26, 2023

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants