Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30596][coordination] Fix duplicate jobs when submitting with the same jobId #22899

Closed

Conversation

mohsenrezaeithe
Copy link
Contributor

Related to #22898, backporting to Flink 1.16 release.
(cherry picked from commit b528d9b)

What is the purpose of the change

The goal of this PR is to protect job submission when multiple POST /jars/:jarid/run requests with the same jobId have been submitted to a cluster.

Brief change log

  • Add a job submission completion check to allow visibility into Dispatcher tasks that may refer to the same jobId.
  • Manage a new submittedAndWaitingTerminationJobIDs to ensure duplicate job IDs are caught when checking isDuplicateJob.

Verifying this change

  • Added a new test that validates two job submissions of the same job graph is detected through the OneShotLatch for parallel submission (ensuring only one submission fails)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@mohsenrezaeithe
Copy link
Contributor Author

@zentol PTAL for 1.16 backport.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 29, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants