[FLINK-32488][REST] Introduce separate configuration to control expiry of E… #22906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmvk Would you be keen on reviewing this PR to improve the configuration of the REST endpoint execution graph cache? P.S.: I couldn't find an easy way to fallback to the |
hlteoh37
changed the title
hlteoh37
changed the title
…xecutionGraph cache
| @@ -20,6 +20,12 @@ | |||
| <td>Long</td> | |||
| <td>The time in ms that the client waits for the leader address, e.g., Dispatcher or WebMonitorEndpoint</td> | |||
| </tr> | |||
| <tr> | |||
| <td><h5>rest.cache.execution-graph.expiry</h5></td> | |||
There was a problem hiding this comment.
Will this config be meaningful to end users? Which REST endpoints does this control? For example, it is not intuitive that this controls the checkpoint list API
| @@ -56,7 +55,6 @@ WebMonitorEndpoint<T> createRestEndpoint( | |||
| static ExecutionGraphCache createExecutionGraphCache( | |||
| RestHandlerConfiguration restConfiguration) { | |||
| return new DefaultExecutionGraphCache( | |||
| restConfiguration.getTimeout(), | |||
| Time.milliseconds(restConfiguration.getRefreshInterval())); | |||
| restConfiguration.getTimeout(), restConfiguration.getExecutionGraphCacheExpiry()); | |||
There was a problem hiding this comment.
I believe this is a backwards incompatible change, that might require a FLIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xecutionGraph cache
What is the purpose of the change
Introduce a new configuration to control the cache expiry for ExecutionGraph cache. This should be separate from the
web.refresh-interval, as that controls the Flink dashboard refresh rate.Brief change log
rest.cache.execution-graph.expiryto control ExecutionGraph expiryVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation