Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32404][table] Add catalog modification listener interface and create listener for catalog manager #22924

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

FangYongs
Copy link
Contributor

What is the purpose of the change

This PR aims to add catalog modification listener interface and create the listeners for catalog manager from configuration

Brief change log

  • Add catalog modification listener interface
  • Create listeners for CatalogManager

Verifying this change

This change added tests and can be verified as follows:

  • Added EnvironmentTest.testCreateCatalogModificationListeners to create specific listeners for CatalogManager from configuration

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 1, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@FangYongs FangYongs force-pushed the FLINK_32404_catalog_listener branch from b0fc06c to 75c6ae1 Compare July 2, 2023 06:56
@FangYongs
Copy link
Contributor Author

Hi @leonardBang @PatrickRen @libenchao Please help to review this PR when you're free, thanks

@PatrickRen PatrickRen self-assigned this Jul 12, 2023
@FangYongs FangYongs force-pushed the FLINK_32404_catalog_listener branch 2 times, most recently from 01552f6 to d546e05 Compare July 12, 2023 15:33
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FangYongs Thanks for the PR. I left some comments.

@FangYongs FangYongs force-pushed the FLINK_32404_catalog_listener branch from 3328a5f to 9c08f77 Compare July 19, 2023 01:28
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FangYongs Thanks for the PR! LGTM.

@PatrickRen PatrickRen merged commit fd96076 into apache:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants