FLINK-3674 Add an interface for EventTime aware User Function (Ram) #2301
Conversation
|
|
||
| /** Flag to prevent duplicate function.close() calls in close() and dispose() */ | ||
| private transient boolean functionsClosed = false; | ||
|
|
||
|
|
||
| public AbstractUdfStreamOperator(F userFunction) { | ||
| this.userFunction = requireNonNull(userFunction); | ||
| if(userFunction instanceof EventTimeFunction) { |
There was a problem hiding this comment.
Thanks for the super quick review. A quick question - In intellij IDE how should a formatting be applied? In Eclipse Ctrl+Shift+F applies the formatter that was configured. How about here? I can update the next commit based on that. Thank you.
There was a problem hiding this comment.
I got that. It is Ctrl+Alt+L here.
|
Created two interfaces EventTimeFunction and a WindowTimer (interface). The WindowTimer interface allows users to implement their own watermark timers and the way they could be fired. The EventTimeFunction could be used with any user defined functions and allows the creation of the WindowTimer. So the WindowOperator will see if the UDF is EventTimeFunction and uses the WindowTimer created by the EventimeFunction. If not it will use the DefaultTimer as in the current case. I ran mvn verify to ensure there are no checkstyle or compilation errors. |
| @Override | ||
| public void apply(String key, | ||
| W window, | ||
| Iterable<Tuple2<String, Integer>> input, |
There was a problem hiding this comment.
this should fail checkstyle, as the indentation is partly done with spaces. we only use tabs.
|
Can we go back to the JIRA issue for a step, and first decide how we actually want his feature to look like? |
|
I would suggest to close this PR and start with a proper design discussion.
In a clean design, this feature should not touch any window operator code. Sorry for that, but that is why we encourage people to share designs before going full on implementing - at least for more complex additions like this one. |
|
Closing this as discussed. I will wait for more feedback on what is expected here and then proceed. |
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
mvn clean verifyhas been executed successfully locally or a Travis build has passed