Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FLINK-28046][connectors] Mark SourceFunction interface as @deprecated" #23018

Merged
merged 1 commit into from Jul 19, 2023

Conversation

ruanhang1993
Copy link
Contributor

What is the purpose of the change

This PR reverts commit 07bf511, which marks SourceFunction interface as @deprecated.

We need to resolve all subtasks in FLINK-28045 and then deprecated SourceFunction interface.

Brief change log

reverts commit 07bf511

Verifying this change

This change is a revert without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

…eprecated"

This reverts commit 07bf511.

We need to resolve all subtasks in FLINK-28045 and then deprecated SourceFunction interface.
@leonardBang leonardBang self-requested a review July 19, 2023 03:18
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 for the work, LGTM

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 19, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@leonardBang leonardBang merged commit 1635a28 into apache:master Jul 19, 2023
@knaufk
Copy link
Contributor

knaufk commented Jul 25, 2023

We need to resolve all subtasks in FLINK-28045 and then deprecated SourceFunction interface.

The vote on deprecating the SourceFunction explicitly stated, that we can deprecate it without having resolved all the subtasks. [1]

[1] https://lists.apache.org/thread/kv9rj3w2rmkb8jtss5bqffhw57or7v8v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants