Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32978] Deprecate RichFunction#open(Configuration parameters) #23058

Closed
wants to merge 2 commits into from

Conversation

WencongLiu
Copy link
Contributor

@WencongLiu WencongLiu commented Jul 24, 2023

What is the purpose of the change

Remove parameter in RichFunction#open.

Brief change log

  • Add a new class OpenContext
  • Add a new method RichFunction#open(OpenConext openContext)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 24, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@WencongLiu WencongLiu changed the title Test for 6912 Remove parameter in RichFunction#open Jul 25, 2023
@WencongLiu WencongLiu force-pushed the dev_FLINK-6912 branch 5 times, most recently from de8a0f8 to 74d04f7 Compare July 25, 2023 12:23
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WencongLiu Thanks for your contribution, I left some comments.

@WencongLiu WencongLiu force-pushed the dev_FLINK-6912 branch 2 times, most recently from 5821d41 to a586297 Compare August 17, 2023 06:44
@WencongLiu WencongLiu force-pushed the dev_FLINK-6912 branch 2 times, most recently from af3dfa3 to 0097f5d Compare August 23, 2023 02:40
@WencongLiu WencongLiu changed the title Remove parameter in RichFunction#open [FLINK-6912] Remove parameter in RichFunction#open Aug 23, 2023
@WencongLiu WencongLiu closed this Aug 23, 2023
@WencongLiu WencongLiu reopened this Aug 23, 2023
@WencongLiu WencongLiu changed the title [FLINK-6912] Remove parameter in RichFunction#open [FLINK-32978] Remove parameter in RichFunction#open Aug 28, 2023
@WencongLiu WencongLiu changed the title [FLINK-32978] Remove parameter in RichFunction#open [FLINK-32978] Deprecate RichFunction#open(Configuration parameters) Aug 28, 2023
@WencongLiu WencongLiu force-pushed the dev_FLINK-6912 branch 2 times, most recently from f9b6564 to d0f066e Compare September 6, 2023 04:21
Comment on lines 73 to 75
public void open(Configuration parameters) throws Exception {
throw new UnsupportedOperationException(
"This method is deprecated and shouldn't be invoked. Please use getDefaultTrigger() instead.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void open(Configuration parameters) throws Exception {
throw new UnsupportedOperationException(
"This method is deprecated and shouldn't be invoked. Please use getDefaultTrigger() instead.");
public void open(Configuration parameters) throws Exception {
throw new UnsupportedOperationException(
"This method is deprecated and shouldn't be invoked. Please use open(OpenContext) instead.");

…iguration parameters) to RichFunction#open(OpenContext openContext)
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants