-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-32978] Deprecate RichFunction#open(Configuration parameters) #23058
Conversation
de8a0f8
to
74d04f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WencongLiu Thanks for your contribution, I left some comments.
...ava/org/apache/flink/table/runtime/operators/over/AbstractRowTimeUnboundedPrecedingOver.java
Show resolved
Hide resolved
5821d41
to
a586297
Compare
af3dfa3
to
0097f5d
Compare
flink-core/src/main/java/org/apache/flink/api/common/functions/RichFunction.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/functions/RichFunction.java
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/functions/OpenContext.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/functions/RichFunction.java
Show resolved
Hide resolved
...st/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperatorLifecycleTest.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/functions/RichFunction.java
Show resolved
Hide resolved
f9b6564
to
d0f066e
Compare
flink-core/src/main/java/org/apache/flink/configuration/OpenContext.java
Outdated
Show resolved
Hide resolved
.../flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/RichIterativeCondition.java
Outdated
Show resolved
Hide resolved
...cessing-api/src/main/java/org/apache/flink/state/api/input/operator/StateReaderOperator.java
Outdated
Show resolved
Hide resolved
d0f066e
to
809820d
Compare
public void open(Configuration parameters) throws Exception { | ||
throw new UnsupportedOperationException( | ||
"This method is deprecated and shouldn't be invoked. Please use getDefaultTrigger() instead."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public void open(Configuration parameters) throws Exception { | |
throw new UnsupportedOperationException( | |
"This method is deprecated and shouldn't be invoked. Please use getDefaultTrigger() instead."); | |
public void open(Configuration parameters) throws Exception { | |
throw new UnsupportedOperationException( | |
"This method is deprecated and shouldn't be invoked. Please use open(OpenContext) instead."); |
…iguration parameters) to RichFunction#open(OpenContext openContext)
809820d
to
634f599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging.
What is the purpose of the change
Remove parameter in RichFunction#open.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes)Documentation