[FLINK-32977] Deprecate IOReadableWritable serialization in Path #23072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsyldliu
approved these changes
Aug 10, 2023
WencongLiu
force-pushed
the
dev_FLINK-5336
branch
from
6d650b7
to
baea50e
Compare
WencongLiu
changed the title
xintongsong
reviewed
Aug 28, 2023
| * @return the path | ||
| * @throws IOException if an error happened. | ||
| */ | ||
| public static Path deserializeFromDataInputView(DataInputView in) throws IOException { |
There was a problem hiding this comment.
Should deduplicate, by calling deserializeFromDataInputView from read.
| throw new IOException("Error reconstructing URI", e); | ||
| } | ||
| } | ||
| return result; |
There was a problem hiding this comment.
Shall we return null if isNotNull is false?
There was a problem hiding this comment.
Actually, I wonder if we should forbid null values.
WencongLiu
changed the title
WencongLiu
force-pushed
the
dev_FLINK-5336
branch
from
fe1e720
to
35aeceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Deprecate IOReadableWritable serialization in Path.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation