-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-32758][python] Remove PyFlink dependencies' upper bounds #23141
Conversation
118206b
to
f59a535
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepyaman Thanks a lot for the feature. Looks good overall. I only have one comment. And maybe we need to trigger pipeline manually more times to validate these changes, as we met some problem in some azure machines previously due to some packages upgrade to new version.
@flinkbot run azure |
1 similar comment
@flinkbot run azure |
@flinkbot run azure |
@deepyaman Thanks a lot for the PR. Big +1 for this improvement. The PR LGTM overall. I found that the change of Cython may break the tests, see https://dev.azure.com/dianfu/Flink/_build/results?buildId=729&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11&t=727942b6-6137-54f7-1ef9-e66e706ea068 (I have triggered nightly tests which will run more tests. Cython tests are skipped in the PR CI) for more details. It seems related to recently released cython 3.0.0. After changing |
@dianfu Sounds great! Let me know if the nightly job raises any other issues. In the meantime, I've gone ahead and updated |
@deepyaman All the tests passed after making the changes of cython. BTW, it seems that there is one minor problem for the latest update. It should be |
Sorry, made a typo in one place; fixed! |
@dianfu @HuangXingBo Do you all have an estimated timeline for when an update PyFlink 1.17 (and possibly 1.18) will be available, now that this has been merged for a while, and the corresponding Jira is closed? |
What is the purpose of the change
This pull request loosens PyFlink dependencies to make the library compatible with a wider range of other Python data libraries, including more recent releases of major libraries like pandas, Ibis, etc.
Brief change log
pd.DataFrame.iteritems()
withpd.DataFrame.items()
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation