[FLINK-32823][doc] Update the adaptive scheduler fall back strategy doc for batch jobs #23187
Conversation
|
Hi @zhuzhurk @JunRuiLee , would you mind helping take a look this PR in your free time? thanks~ This is a minor change about batch adaptive scheduler doc. |
There was a problem hiding this comment.
@1996fanrui Thanks for your contribution. LGTM, just left a minor comment.
| @@ -141,7 +141,7 @@ Adaptive 调度器可以通过[所有在名字包含 `adaptive-scheduler` 的配 | |||
|
|
|||
| ### 局限性 | |||
|
|
|||
| - **只支持流式 Job**：Adaptive 调度器的第一个版本仅支持流式 Job。当提交的是一个批处理 Job 时，我们会自动换回默认调度器。 | |||
| - **只支持流式 Job**：Adaptive 调度器的仅支持流式 Job。当提交的是一个批处理 Job 时，我们会自动换回 Adaptive Batch Scheduler。 | |||
There was a problem hiding this comment.
| - **只支持流式 Job**：Adaptive 调度器的仅支持流式 Job。当提交的是一个批处理 Job 时，我们会自动换回 Adaptive Batch Scheduler。 | |
| - **只支持流式 Job**：Adaptive 调度器仅支持流式 Job。当提交的是一个批处理 Job 时，我们会自动换回 Adaptive Batch Scheduler。 |
There was a problem hiding this comment.
Thanks @lsyldliu for the quick review!
Good catch, it's my mistake. Updated.
1996fanrui
force-pushed
the
32823/update-batch-adaptive-doc
branch
from
e63ef3f
to
0126f61
Compare
|
@1996fanrui Thanks for looking into and fix this problem! |
1996fanrui
force-pushed
the
32823/update-batch-adaptive-doc
branch
from
0126f61
to
868c49d
Compare
| @@ -143,7 +143,7 @@ The behavior of Adaptive Scheduler is configured by [all configuration options c | |||
|
|
|||
| ### Limitations | |||
|
|
|||
| - **Streaming jobs only**: The first version of Adaptive Scheduler runs with streaming jobs only. When submitting a batch job, we will automatically fall back to the default scheduler. | |||
| - **Streaming jobs only**: The Adaptive Scheduler runs with streaming jobs only. When submitting a batch job, we will automatically fall back to the Adaptive Batch Scheduler. | |||
There was a problem hiding this comment.
we will automatically fall back to the Adaptive Batch Scheduler -> Flink will use the default scheduler of batch jobs, i.e. Adaptive Batch Scheduler
Looks to me the statement of fall back is kind of misleading, because Adaptive Batch Scheduler is not the default scheduler in all cases (like DefaultScheduler was)
There was a problem hiding this comment.
Thanks a lot @zhuzhurk for the review and good suggestions.
Sounds make sense to me, updated~
| @@ -141,7 +141,7 @@ Adaptive 调度器可以通过[所有在名字包含 `adaptive-scheduler` 的配 | |||
|
|
|||
| ### 局限性 | |||
|
|
|||
| - **只支持流式 Job**：Adaptive 调度器的第一个版本仅支持流式 Job。当提交的是一个批处理 Job 时，我们会自动换回默认调度器。 | |||
| - **只支持流式 Job**：Adaptive 调度器仅支持流式 Job。当提交的是一个批处理 Job 时，我们会自动换回 Adaptive Batch Scheduler。 | |||
There was a problem hiding this comment.
我们会自动换回 Adaptive Batch Scheduler -> Flink 会自动使用批处理 Job 的默认调度器，即 Adaptive Batch Scheduler
…oc for batch jobs
1996fanrui
force-pushed
the
32823/update-batch-adaptive-doc
branch
from
868c49d
to
44b1b53
Compare
|
Thanks to everyone who helped review, CI passed, merging~ |
What is the purpose of the change
FLINK-30846 [1] updated the fall back strategy from default Scheduler to AdaptiveBatch Scheduler when batch job enable
jobmanager.scheduler: adaptive.However, the doc[2] isn't updated.
Brief change log
[FLINK-32823][doc] Update the adaptive scheduler fall back strategy doc for batch jobs
[1] https://github.com/apache/flink/pull/21814/files
[2] https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/elastic_scaling/#limitations-1