[FLINK-32809][yarn] Fixes YarnClusterDescriptor#isArchiveOnlyIncluded…

[qinf]

…InShipArchiveFiles dose not work as expected

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

• Fixed YarnClusterDescriptor#isArchiveonlyincludedinShipArchiveFiles dose not work as expected

Verifying this change

This change added tests and can be verified as follows:

• *Added test that validates that YarnConfigOptions.SHIP_ARCHIVES only support archive files *

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

CI report:

• b9c43dd Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[qinf]

Hi @1996fanrui would you mind helping review this PR in your free time?
It's a minor change, it just fixed YarnClusterDescriptor#isArchiveOnlyIncludedInShipArchiveFiles does not work as expected.

[1996fanrui]

Hi @qinf , thanks for your fix.

Overall is good, I have left a few comments, please take a look, thanks~

[1996fanrui]

Hi @qinf , could you update the commit message to [FLINK-32809][yarn] Fix the bug that there is no check when yarn.ship-archives configures the directory?

It's more specific, and everyone can see what doesn't meet expectations.

[1996fanrui]

Thanks @qinf for the quick update!

The change LGTM!

Hi @RocMarshal , would you mind helping take a look this PR in your free time as well? thanks~

[RocMarshal]

Thanks @qinf for the contribution and @1996fanrui for the review.
Looks good to me on the whole just left a few of comment.
PTAL in your free time.

[RocMarshal]

Could these two lines be inlined?
Because there's no filters between the two maps

[RocMarshal]

Is there a possibility of frequent changes in the suffix format here?
If so, would you consider introducing a parameter to specify the suffix format?

Please correct me if I'm wrong in my limited read.

[qinf]

@RocMarshal The archive types have not changed for over 2 years, maybe it is a good time to do this when there is a new archive type need to add here.

[RocMarshal]

LGTM +1. Thanks @qinf
CC @1996fanrui

[1996fanrui]

Thanks @RocMarshal for the review, merging~