[FLINK-32845][JUnit5 Migration] Migrate the memory and messages packages of flink-runtime module to junit5 #23197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges of flink-runtime module to junit5
1996fanrui
force-pushed
the
32845/memory-message-junit5
branch
from
33cbbab
to
909ac5d
Compare
|
Hi @Jiabao-Sun , would you mind helping take a look this PR in your free time? thanks~ |
Jiabao-Sun
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Thanks @1996fanrui for this contribution.
It looks all good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FLINK-32845][JUnit5 Migration] Migrate the memory and messages packages of flink-runtime module to junit5