Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32844][table-planner] Does not apply runtime filter and DPP on same key #23215

Closed
wants to merge 1 commit into from

Conversation

wanglijie95
Copy link
Contributor

What is the purpose of the change

Fix FLINK-32844, does not apply runtime filter and DPP on same key

Verifying this change

Add test testDoesNotApplyRuntimeFilterAndDPPOnSameKey

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@wanglijie95
Copy link
Contributor Author

Hi @lsyldliu, could you help to review this PR when you are free?

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 15, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanglijie95 Thanks for your contribution, LGTM

@wanglijie95 wanglijie95 deleted the FLINK-32844 branch August 16, 2023 06:21
wanglijie95 added a commit to wanglijie95/flink that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants