[FLINK-32888] Handle hasNext() throwing EndOfDataDecoderException #23229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XComp
reviewed
Aug 17, 2023
flink-runtime/src/test/java/org/apache/flink/runtime/rest/MultipartUploadExtension.java
Outdated
Show resolved
Hide resolved
XComp
reviewed
Aug 17, 2023
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
Show resolved
Hide resolved
This _probably_ happens when a non-empty http content is received that does not contain any attribute data.
XComp
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpPostRequestDecoder#hasNext() throws an
EndOfDataDecoderExceptionwhen called if all attributes were already read. There is apparently an edge-case where the a non empty HttpContent is received, but we already retrieved all attributes (so I guess it's just multipart metadata).We now assume that this isn't a problem; if it is the application layer should notice it (e.g., if a file/attribute is missing).