Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32879][flink-runtime]Ignore slotmanager.max-total-resource.cpu… #23231

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

xiangyuf
Copy link
Contributor

What is the purpose of the change

Just as slotmanager.number-of-slots.max, we should also ignore the cpu and memory limitation in standalone mode.

Brief change log

  • Add StandaloneResourceManagerFactory#overwriteMaxResourceNumConfig to remove both max slot/cpu/memory limit option.

Verifying this change

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager(StandaloneResourceManagerFactory)
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 17, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xiangyuf
Copy link
Contributor Author

Hi @KarmaGYZ , all comments have been resolved, thx again for reviewing.

@xiangyuf xiangyuf requested a review from KarmaGYZ August 17, 2023 12:45
@huwh
Copy link
Contributor

huwh commented Aug 17, 2023

Hi, @xiangyuf , this pr belongs to https://issues.apache.org/jira/browse/FLINK-32879, Please update the commit message and PR title

@xiangyuf xiangyuf changed the title [FLINK-32880][flink-runtime]Ignore slotmanager.max-total-resource.cpu… [FLINK-32879][flink-runtime]Ignore slotmanager.max-total-resource.cpu… Aug 18, 2023
@xiangyuf
Copy link
Contributor Author

Hi, @xiangyuf , this pr belongs to https://issues.apache.org/jira/browse/FLINK-32879, Please update the commit message and PR title

Hi @huwh , thanks for reply. Commit message and pr tittle has updated.

@huwh huwh merged commit c8cbb0e into apache:master Aug 18, 2023
xiangyuf added a commit to xiangyuf/flink that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants