[FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/registration tests to JUnit5 #23300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion tests to JUnit5
X-czh
changed the title
|
Hi @1996fanrui, could you review the change when you are free, much appreciated~ |
|
Hi @FangYongs, could you review the change when you are free? |
FangYongs
reviewed
Sep 14, 2023
|
|
||
| /** Tests for RegisteredRpcConnection, validating the successful, failure and close behavior. */ | ||
| public class RegisteredRpcConnectionTest extends TestLogger { | ||
| class RegisteredRpcConnectionTest { |
There was a problem hiding this comment.
You may need to add @ExtendWith(TestLoggerExtension.class) for RegisteredRpcConnectionTest after removing extends TestLogger
FangYongs
reviewed
Sep 14, 2023
|
|
||
| /** Tests for the {@link RetryingRegistrationConfiguration}. */ | ||
| public class RetryingRegistrationConfigurationTest extends TestLogger { | ||
| class RetryingRegistrationConfigurationTest { |
There was a problem hiding this comment.
Hi, we reached agreement with Fan Rui and Matthias Pohl previously that we should not add @ExtendWith(TestLoggerExtension.class) explicitly for each class but rather enable it globally in Junit5 configs. See https://issues.apache.org/jira/browse/FLINK-32866
FangYongs
reviewed
Sep 14, 2023
| @@ -59,28 +54,28 @@ | |||
| * Tests for the generic retrying registration class, validating the failure, retry, and back-off | |||
| * behavior. | |||
| */ | |||
| public class RetryingRegistrationTest extends TestLogger { | |||
| class RetryingRegistrationTest { | |||
|
Thanks @X-czh for contribution, just some minor comments |
|
Thanks @X-czh , LGTM +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate flink-runtime/registration tests to JUnit5.
Verifying this change
The change itself is for migrating UT.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation