-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/rpc tests to JUnit5 #23301
Conversation
Hi @1996fanrui, could you review the change when you are free, much appreciated~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @X-czh! Left some comments.
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/FencedRpcEndpointTest.java
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/FencedRpcEndpointTest.java
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcEndpointTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcSSLAuthITCase.java
Outdated
Show resolved
Hide resolved
@ferenc-csaky Thanks for the suggestions! I've improved them, help review again when you have time, thanks in advance~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @X-czh! LGTM!
c4b4150
to
dc1e8e1
Compare
Squashed commits to clean up the commit history. @FangYongs Could you help take a look when you have time? |
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/AsyncCallsTest.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/RpcSSLAuthITCase.java
Outdated
Show resolved
Hide resolved
@FangYongs Thanks for the careful review, I've corrected the two mistakes, please review again when you have time~ |
Thanks @X-czh for contributions, LGTM |
The CI is failed due to failed download of node-16.13.2-linux-x64.tar.gz, re-run it |
@flinkbot run azure |
What is the purpose of the change
Migrate flink-runtime/rpc tests to JUnit5.
Verifying this change
The change itself is for migrating UT.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation