Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32848][tests][JUnit5 migration] Migrate flink-runtime/rpc tests to JUnit5 #23301

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Aug 26, 2023

What is the purpose of the change

Migrate flink-runtime/rpc tests to JUnit5.

Verifying this change

The change itself is for migrating UT.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 26, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@X-czh
Copy link
Contributor Author

X-czh commented Sep 11, 2023

Hi @1996fanrui, could you review the change when you are free, much appreciated~

Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @X-czh! Left some comments.

@X-czh
Copy link
Contributor Author

X-czh commented Sep 14, 2023

@ferenc-csaky Thanks for the suggestions! I've improved them, help review again when you have time, thanks in advance~

Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @X-czh! LGTM!

@X-czh
Copy link
Contributor Author

X-czh commented Sep 15, 2023

Squashed commits to clean up the commit history. @FangYongs Could you help take a look when you have time?

@X-czh
Copy link
Contributor Author

X-czh commented Sep 18, 2023

@FangYongs Thanks for the careful review, I've corrected the two mistakes, please review again when you have time~

@FangYongs
Copy link
Contributor

Thanks @X-czh for contributions, LGTM

@FangYongs
Copy link
Contributor

The CI is failed due to failed download of node-16.13.2-linux-x64.tar.gz, re-run it

@FangYongs
Copy link
Contributor

@flinkbot run azure

@FangYongs FangYongs merged commit f2cb1d2 into apache:master Sep 21, 2023
@X-czh X-czh deleted the FLINK-32848-rpc branch September 21, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants