Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32965][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests #23303

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

1996fanrui
Copy link
Member

@1996fanrui 1996fanrui commented Aug 27, 2023

What is the purpose of the change

FLINK-1285 updated the MutableObjectMode to ObjectReuse. The TaskConfig#getMutableObjectMode() is not used for a long long time, and it's internal class, so it can be removed directly.

Also, we should update the GroupReduceDriverTest:

  • Updating the testAllReduceDriverAccumulatingImmutable() from context.setMutableObjectMode(false); to context.getExecutionConfig().disableObjectReuse();.
  • Updating the testAllReduceDriverIncorrectlyAccumulatingMutable() to context.getExecutionConfig().disableObjectReuse();, and fix the assert.

More details can be get from #23233 (comment)

Brief change log

  • [FLINK-32965][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests
  • [FLINK-32965][flink-runtime][hotfix] Refactor some code with code style warning

Verifying this change

Improve the old tests:

  • GroupReduceDriverTest#testAllReduceDriverIncorrectlyAccumulatingMutable
  • GroupReduceDriverTest#testAllReduceDriverAccumulatingImmutable

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@1996fanrui
Copy link
Member Author

Hi @Jiabao-Sun @RocMarshal would you mind helping review this PR in your free time? thanks~

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 27, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@1996fanrui 1996fanrui force-pushed the 32965/remove-MutableObjectMode branch from dbefa1e to ba6d6da Compare August 27, 2023 06:21
@1996fanrui 1996fanrui changed the title [FLINK-32847][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests [FLINK-32965][flink-runtime] Removing the deprecated MutableObjectMode and restore related tests Aug 27, 2023
Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1996fanrui for this change, LGTM!

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @1996fanrui
Thanks for the contribution and ping.
LGTM +1.

Copy link
Member Author

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ferenc-csaky and @RocMarshal for the review, merging~

@1996fanrui 1996fanrui merged commit 32b63c8 into apache:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants