Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32980][scripts] Support env.java.opts.all & env.java.opts.cli config for starting Session cluster CLIs #23308

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Aug 28, 2023

What is the purpose of the change

Support env.java.opts.all & env.java.opts.cli config for starting Session cluster CLIs.

Brief change log

Append JVM args set by env.java.opts.all & env.java.opts.cli which are read from the flink-conf files.

Verifying this change

Manually verified the change by running the relevant scripts.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 28, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this PR, LGTM

@huwh huwh merged commit 6dbb9b8 into apache:master Aug 29, 2023
@X-czh X-czh deleted the FLINK-32980 branch August 29, 2023 02:49
xiangyuf pushed a commit to xiangyuf/flink that referenced this pull request Nov 16, 2023
…config for starting Session cluster CLIs (apache#23308)

(cherry picked from commit 6dbb9b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants