Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32523][test] Guarantee all operators triggering decline checkpoint together for NotifyCheckpointAbortedITCase#testNotifyCheckpointAborted #23333

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

masteryhx
Copy link
Contributor

What is the purpose of the change

This pr wants to fix assert error for NotifyCheckpointAbortedITCase#testNotifyCheckpointAborted
: All operators haven't snapshotState together strictly for marked decline checkpoint id in the teste case (This could be reproduced by adding Thread.sleep after first verifyAllOperatorsNotifyAborted() )

I think we could just make them snapshotState together strictly which I think the ITCase should guarantee.

Brief change log

  • Guarantee all operators triggering marked decline checkpoint id together

Verifying this change

This change just fix the error ITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

…oint together for NotifyCheckpointAbortedITCase#testNotifyCheckpointAborted

(cherry picked from commit 66cc21d)
@flinkbot
Copy link
Collaborator

flinkbot commented Aug 30, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@masteryhx
Copy link
Contributor Author

@flinkbot run azure

@masteryhx masteryhx merged commit 001fccd into apache:release-1.17 Aug 31, 2023
RocMarshal pushed a commit to RocMarshal/flink that referenced this pull request May 9, 2024
…oint together for NotifyCheckpointAbortedITCase#testNotifyCheckpointAborted (apache#23333)

(cherry picked from commit 66cc21d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants