Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.18][FLINK-32999][connectors/hbase] Remove HBase connector code from main repo #23343

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

ferenc-csaky
Copy link
Contributor

What is the purpose of the change

Removes HBase connector code from the main repo, as the HBase connector is externalized to the flink-connector-hbase repo. This can only be merged once the external HBase connector is released.

Brief change log

Delete all HBase connector classes and adapt the POMs.

Verifying this change

For the first release, the externalized repo will hace the same content and test coverage as it was in the main repo.
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 31, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor

Thanks for your contribution @ferenc-csaky
the build is still failiing

it seems some more things should be done I addressed them and submitted as a PR to your branch, the build is green after that, please have a look ferenc-csaky#2

@ferenc-csaky
Copy link
Contributor Author

@snuyanzin can you merge this one as well?

Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferenc-csaky thanks a lot for the contribution

LGTM
As it was discussed during release meeting with @knaufk it is ok to merge it since anyway HBase connector was released together with 1.17 then for 1.18+ it could be removed and externalized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants