Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4334] [quickstarts] Correctly exclude hadoop1 in quickstart POMs #2341

Conversation

rehevkor5
Copy link
Contributor

@rehevkor5 rehevkor5 commented Aug 8, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@StephanEwen
Copy link
Contributor

Thanks, this makes a lot of sense.

We should merge this for Flink 1.1.1
For Flink 1.2.0, we should actually fix the root issue, which is that the hadoop1 artifact has a scala suffix even though it does not need one. I think this was introduced by accident.

@StephanEwen
Copy link
Contributor

I merged this into the 1.1 release branch.
For the 1.2 releases, we should use this fix: #2343

@StephanEwen
Copy link
Contributor

@rehevkor5 Since the Apache bot does not automatically close this pull request, could you close it manually?

@rehevkor5
Copy link
Contributor Author

You got it @StephanEwen

@rehevkor5 rehevkor5 closed this Aug 9, 2016
@rehevkor5 rehevkor5 deleted the fix_hadoop1_not_excluded_in_quickstarts branch August 9, 2016 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants