Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory #23449

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

Jiabao-Sun
Copy link
Contributor

@Jiabao-Sun Jiabao-Sun commented Sep 21, 2023

What is the purpose of the change

[FLINK-33000][sql-gateway] SqlGatewayServiceITCase, ResultFetcherTest and OperationManagerTest should utilize TestExecutorExtension instead of using a ThreadFactory

Brief change log

SqlGatewayServiceITCase, ResultFetcherTest and OperationManagerTest should utilize TestExecutorExtension instead of using a ThreadFactory

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…tExecutorExtension instead of using a ThreadFactory
@flinkbot
Copy link
Collaborator

flinkbot commented Sep 21, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Jiabao-Sun
Copy link
Contributor Author

Hi @fsk119, could you help review it when you have time?
Thanks.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response...

LGTM

@fsk119 fsk119 merged commit 8e68b40 into apache:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants