Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33289] Fix the conversion of InetSocketAddress to URL in Network utils to work with ipv6 address correctly #23530

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

caodizhou
Copy link

What is the purpose of the change

Fix the failure of creating a connection when the gateway address is an IPv6 address.

Brief change log

  • Fix NetUtils.socketToUrl to work properly if the hostString in the socketAddress is an IPv6 address.

Verifying this change

  • Add testIpv6SocketToUrl and testIpv4SocketToUrl in NetUtilsTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@caodizhou caodizhou changed the title [(FLINK-33289] Fix the conversion of InetSocketAddress to URL in Netw… [FLINK-33289] Fix the conversion of InetSocketAddress to URL in Network utils to work with ipv6 address correctly Oct 18, 2023
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 18, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@KarmaGYZ KarmaGYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @caodizhou . LGTM

…rk utils to work with ipv6 address correctly
@KarmaGYZ KarmaGYZ merged commit 1182d15 into apache:master Oct 18, 2023
@caodizhou caodizhou deleted the FLINK-33289 branch October 18, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants