[FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module #23572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @XComp, @1996fanrui, @RocMarshal. |
Jiabao-Sun
force-pushed
the
flink-io-disk
branch
from
4d78633
to
7ff770f
Compare
|
Hi @RocMarshal, please help review it when you have time. |
RocMarshal
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Hi, @Jiabao-Sun Thanks for your hard work.
LGTM on the whole.
Only left a comment.
PTAL in your free time.
|
|
||
| import java.io.EOFException; | ||
| import java.util.List; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
| import static org.assertj.core.api.AssertionsForClassTypes.assertThat; |
There was a problem hiding this comment.
Shoud the line be repalced by import static org.assertj.core.api.Assertions.assertThat ?
There was a problem hiding this comment.
Thanks @RocMarshal for the hard review.
Fixed.
RocMarshal
approved these changes
Oct 25, 2023
|
@1996fanrui, please help review it when you have time. |
1996fanrui
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thanks @Jiabao-Sun for your effort, and @RocMarshal for your review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module
Brief change log
[FLINK-32850][flink-runtime][JUnit5 Migration] The io.disk package of flink-runtime module
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation