Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4198] Replace org.apache.flink.streaming.api.windowing.time.Ti… #2359

Closed
wants to merge 1 commit into from

Conversation

kishorekgarg
Copy link

@kishorekgarg kishorekgarg commented Aug 11, 2016

Removed org.apache.flink.streaming.api.windowing.time.Time and replaced it with org.apache.flink.api.common.time.Time which resides in flink-core.

…me with org.apache.flink.api.common.time.Time
@StephanEwen
Copy link
Contributor

I think this breaks the API compatibility.
This issue was scheduled as part of the API breaking changes for FLINK 2.0

Compatibility for @Public annotated methods is something we promised in the 1.0 release, so we have to stick with it.

@StephanEwen
Copy link
Contributor

We can unfortunately not merge this change. The tools for API compatibility verify that this breaks the API:

Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.7.0:cmp (default) on project flink-streaming-java_2.10: Breaking the build because there is at least one binary incompatible class: org.apache.flink.streaming.api.datastream.DataStream

The issue has been scheduled for Flink 2.0 - let's redo once this is on the horizon. Could you close the pull request?

@kishorekgarg
Copy link
Author

Sure. I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants