Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33364][core] Introduce standard YAML for flink configuration. #23606

Closed

Conversation

JunRuiLee
Copy link
Contributor

@JunRuiLee JunRuiLee commented Oct 27, 2023

What is the purpose of the change

Introduce standard YAML for flink configuration.

Brief change log

  • Use snakeyaml as the standard yaml parser and introduce standard YAML for flink configuration.

Verifying this change

  • Update ConfigurationTest, ConfigurationUtilsTest, GlobalConfigurationTest to parameterized tests, which will test both new and legacy configuration approaches separately.
  • Add YamlParserUtilsTest to test the standard YAML parser.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 27, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch from 7b95683 to 4d67254 Compare October 27, 2023 09:28
@zhuzhurk zhuzhurk self-assigned this Oct 27, 2023
@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch 2 times, most recently from 0eeecd1 to 30b8cc5 Compare October 29, 2023 11:43
@JunRuiLee JunRuiLee changed the title [FLINK-33364] Introduce standard YAML for flink configuration. [FLINK-33364][core] Introduce standard YAML for flink configuration. Oct 29, 2023
@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch 2 times, most recently from f2bbe08 to 904a4ea Compare October 30, 2023 02:13
@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch 2 times, most recently from 6097163 to 34575d5 Compare November 16, 2023 09:42
@JunRuiLee
Copy link
Contributor Author

@flinkbot run azure

@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch from 18e6999 to b4559b2 Compare November 28, 2023 07:39
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @JunRuiLee
Just some minor comments.

@JunRuiLee
Copy link
Contributor Author

@zhuzhurk Thanks for your review, I've updated this pr accordingly. PTAL.

@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch from ef2f95c to 91e473f Compare November 29, 2023 11:31
@JunRuiLee JunRuiLee force-pushed the FLIP366-part1-introduce_standard_yaml branch from 91e473f to 3dab6ee Compare November 30, 2023 02:17
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants