-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33364][core] Introduce standard YAML for flink configuration. #23606
Closed
JunRuiLee
wants to merge
5
commits into
apache:master
from
JunRuiLee:FLIP366-part1-introduce_standard_yaml
Closed
[FLINK-33364][core] Introduce standard YAML for flink configuration. #23606
JunRuiLee
wants to merge
5
commits into
apache:master
from
JunRuiLee:FLIP366-part1-introduce_standard_yaml
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
from
October 27, 2023 09:28
7b95683
to
4d67254
Compare
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
2 times, most recently
from
October 29, 2023 11:43
0eeecd1
to
30b8cc5
Compare
JunRuiLee
changed the title
[FLINK-33364] Introduce standard YAML for flink configuration.
[FLINK-33364][core] Introduce standard YAML for flink configuration.
Oct 29, 2023
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
2 times, most recently
from
October 30, 2023 02:13
f2bbe08
to
904a4ea
Compare
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
2 times, most recently
from
November 16, 2023 09:42
6097163
to
34575d5
Compare
@flinkbot run azure |
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
from
November 28, 2023 07:39
18e6999
to
b4559b2
Compare
zhuzhurk
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! @JunRuiLee
Just some minor comments.
flink-core/src/main/java/org/apache/flink/configuration/YamlParserUtils.java
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/YamlParserUtils.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/YamlParserUtils.java
Show resolved
Hide resolved
@zhuzhurk Thanks for your review, I've updated this pr accordingly. PTAL. |
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
from
November 29, 2023 11:31
ef2f95c
to
91e473f
Compare
zhuzhurk
reviewed
Nov 29, 2023
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java
Outdated
Show resolved
Hide resolved
JunRuiLee
force-pushed
the
FLIP366-part1-introduce_standard_yaml
branch
from
November 30, 2023 02:17
91e473f
to
3dab6ee
Compare
zhuzhurk
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce standard YAML for flink configuration.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation