Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18286] Implement type inference for functions on composite types #23622

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

This ports ELEMENT/ITEM_AT/CARDINALITY functions to the new type inference stack. The end goal is to get rid off PlannerTypeInferenceUtil.

Verifying this change

All existing IT tests pass.
Added tests for the introduced strategies.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 30, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dawidwys dawidwys force-pushed the port-collections-type-inference branch 3 times, most recently from b6000f6 to 128b39a Compare October 31, 2023 11:59
Copy link
Contributor

@jnh5y jnh5y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may be some unused imports, but I'm happy.

@dawidwys dawidwys force-pushed the port-collections-type-inference branch from 128b39a to f5619d3 Compare November 3, 2023 12:47
@dawidwys dawidwys merged commit fa8ea3f into apache:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants