Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33474][runtime-web] fix undefined error of show plan in job su… #23677

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

yuchen-ecnu
Copy link
Contributor

…bmit page

What is the purpose of the change

Fix the undefined exception of Plan Visualization in the Job Submit Page on Flink WEB.

Brief change log

  • Before calling flush of dagreComponent, call cdr.detectChanges() first to make sure dagreComponent loaded

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@yuchen-ecnu
Copy link
Contributor Author

Hi @Myasuka, would you like to help review this PR?

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 7, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Myasuka Myasuka merged commit 008e191 into apache:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants