Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33629][test] Introduce ArchTest rules to ban Junit 4 for modules already completed the migration #23790

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Jiabao-Sun
Copy link
Contributor

What is the purpose of the change

[FLINK-33629][test] Introduce ArchTest rules to ban Junit 4 for modules already completed the migration

Brief change log

Currently, many modules have already completed the migration to JUnit 5, and we need to prevent the introduction of JUnit 4 tests in new PRs.

However, completely removing the dependency on JUnit 4 is challenging. It requires defining JUnit 4 as optional in the flink-parent module and allowing sub-modules to selectively include it. However, this approach still cannot solve the issue of transitive dependencies.

Therefore, considering introducing new rules in ArchTest to prohibit the usage of JUnit 4 in modules that have already completed the migration.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 24, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Jiabao-Sun
Copy link
Contributor Author

Hi @leonardBang, @JingGe.
Please help take a look when you have time.
Thanks.

@leonardBang leonardBang self-requested a review November 24, 2023 08:35
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiabao-Sun for the contribution, LGTM

@leonardBang leonardBang merged commit 34436e7 into apache:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants