Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26010] Develop archunit test for filesystem test code #23798

Merged
merged 8 commits into from Nov 29, 2023

Conversation

JingGe
Copy link
Contributor

@JingGe JingGe commented Nov 25, 2023

What is the purpose of the change

Develop archunit test for filesystem test code

Verifying this change

This change are new archunit tests without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 25, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JingGe JingGe force-pushed the FLINK-26010-archunit-test-code branch from 0d7a074 to b8e3b3c Compare November 25, 2023 07:32
@JingGe JingGe changed the title Develop archunit test for filesystem test code [FLINK-26010] Develop archunit test for filesystem test code Nov 25, 2023
@JingGe JingGe force-pushed the FLINK-26010-archunit-test-code branch from b8e3b3c to d1f6bd2 Compare November 25, 2023 15:28
@LadyForest LadyForest self-requested a review November 27, 2023 06:41
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JingGe Thanks for the PR! LGTM and just found a typo in pom.

flink-filesystems/flink-azure-fs-hadoop/pom.xml Outdated Show resolved Hide resolved
@JingGe JingGe force-pushed the FLINK-26010-archunit-test-code branch from d1f6bd2 to 7a89d56 Compare November 28, 2023 15:54
@JingGe JingGe merged commit d3270c9 into apache:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants