New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33702][core] Add the IncrementalDelayRetryStrategy implementation of RetryStrategy #23834
Conversation
b85ed15
to
9fa6ba3
Compare
20c0ca0
to
36b0f20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiangyuf for preparing this PR. I left some comments, PTAL
...k-core/src/test/java/org/apache/flink/util/concurrent/IncrementalDelayRetryStrategyTest.java
Outdated
Show resolved
Hide resolved
...k-core/src/test/java/org/apache/flink/util/concurrent/IncrementalDelayRetryStrategyTest.java
Outdated
Show resolved
Hide resolved
...k-core/src/test/java/org/apache/flink/util/concurrent/IncrementalDelayRetryStrategyTest.java
Outdated
Show resolved
Hide resolved
...k-core/src/test/java/org/apache/flink/util/concurrent/IncrementalDelayRetryStrategyTest.java
Outdated
Show resolved
Hide resolved
b85b127
to
4a40f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment, please take a look
flink-core/src/test/java/org/apache/flink/util/concurrent/FixedRetryStrategyTest.java
Outdated
Show resolved
Hide resolved
…nentialBackoffRetryStrategyTest to Junit5 and Assertj
…ion of RetryStrategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging now
What is the purpose of the change
RetryStrategy now supports FixedRetryStrategy and ExponentialBackoffRetryStrategy.
In certain scenarios, we also need IncrementalDelayRetryStrategy to reduce the retry count and perform the action more timely.
Brief change log
IncrementalDelayRetryStrategy
implementation ofRetryStrategy
IncrementalDelayRetryStrategy
will increase the retry delay at a fixed rate for each attemptVerifying this change
This change added tests and can be verified as follows:
IncrementalDelayRetryStrategyTest
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation