Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33702][core] Add the IncrementalDelayRetryStrategy implementation of RetryStrategy #23834

Merged
merged 2 commits into from Dec 5, 2023

Conversation

xiangyuf
Copy link
Contributor

@xiangyuf xiangyuf commented Nov 30, 2023

What is the purpose of the change

RetryStrategy now supports FixedRetryStrategy and ExponentialBackoffRetryStrategy.
In certain scenarios, we also need IncrementalDelayRetryStrategy to reduce the retry count and perform the action more timely.

Brief change log

  • Add the IncrementalDelayRetryStrategy implementation of RetryStrategy
  • IncrementalDelayRetryStrategy will increase the retry delay at a fixed rate for each attempt

Verifying this change

This change added tests and can be verified as follows:

  • Added unit test IncrementalDelayRetryStrategyTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 30, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xiangyuf xiangyuf force-pushed the FLINK-33702 branch 2 times, most recently from 20c0ca0 to 36b0f20 Compare December 1, 2023 16:01
@xiangyuf xiangyuf changed the title [FLINK-33702][datastream] Add IncrementalDelayRetryStrategy in AsyncRetryStrategies [FLINK-33702][core] Add the IncrementalDelayRetryStrategy implementation of RetryStrategy Dec 1, 2023
Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiangyuf for preparing this PR. I left some comments, PTAL

@xiangyuf xiangyuf force-pushed the FLINK-33702 branch 3 times, most recently from b85b127 to 4a40f07 Compare December 4, 2023 15:01
@xiangyuf xiangyuf requested a review from huwh December 5, 2023 00:59
Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment, please take a look

Copy link
Contributor

@huwh huwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging now

@huwh huwh merged commit 0acfc1a into apache:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants