Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33759] flink parquet writer support write nested array or map type #23881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LoveHeat
Copy link

@LoveHeat LoveHeat commented Dec 6, 2023

What is the purpose of the change

see: FLINK-33759

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@ViktorCosenza
Copy link

Hi, I'm having a issue directly related to the empty "write" methods when trying to write a Parquet with an array of row.

I've noticed you fixed the issue for the Map and Array Writer type, but not for RowWriter. So if you wanted to fix it in there to it's probably a very similar fix and in the same file.

https://github.com/apache/flink/pull/23881/files#diff-268b0e6102435b8b1cbde023bd8842beebf677c25cfeeab64a0c92ab182d6cceR486

@xccui
Copy link
Member

xccui commented May 10, 2024

Hi @LoveHeat, can you cherry-pick the change in #24029 from @ukby1234 and merge the two PRs?

@ViktorCosenza
Copy link

ViktorCosenza commented May 15, 2024

Hi @LoveHeat, can you cherry-pick the change in #24029 from @ukby1234 and merge the two PRs?

Hey @xccui, I've created a PR cherry picking both commits: #24795

@LoveHeat LoveHeat closed this May 16, 2024
@LoveHeat LoveHeat reopened this May 16, 2024
@LoveHeat
Copy link
Author

LoveHeat commented May 16, 2024

Hi @LoveHeat, can you cherry-pick the change in #24029 from @ukby1234 and merge the two PRs?

sorry,just saw this~ @xccui @ViktorCosenza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants