Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33736][Scheduler] Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier #23911

Conversation

1996fanrui
Copy link
Member

@1996fanrui 1996fanrui commented Dec 12, 2023

What is the purpose of the change

See FLIP-364: Improve the exponential-delay restart-strategy . This PR includes the subtask1 of FLIP-364.

Brief change log

  • [FLINK-33736][Scheduler] Update default value of exponential-delay.max-backoff and exponential-delay.backoff-multiplier

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? Java doc and config doc are updated.

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 12, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@1996fanrui 1996fanrui force-pushed the 33736/change-default-value-exponential-delay branch from 4f20956 to 626ac31 Compare December 25, 2023 13:47
…x-backoff and exponential-delay.backoff-multiplier
@1996fanrui 1996fanrui force-pushed the 33736/change-default-value-exponential-delay branch from 626ac31 to 6d010a2 Compare December 25, 2023 13:47
Copy link
Member Author

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RocMarshal , would you mind helping take a look this PR in your free time? Thanks~

The default value of multiplier is updated to 1.5, and it has been voted via this thread[1].

[1] https://lists.apache.org/thread/0b1dcwb49owpm6v1j8rhrg9h0fvs5nkt

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @1996fanrui Thanks for driving this. Great ~
LGTM +1 ! (reviewed based on the discussion thread and the flip page)
And I want to pay tribute to you and all those working in this improvement.

@1996fanrui
Copy link
Member Author

Thanks @RocMarshal for the quick review! Merging~

@1996fanrui 1996fanrui merged commit d9e8b2a into apache:master Dec 26, 2023
@1996fanrui 1996fanrui deleted the 33736/change-default-value-exponential-delay branch December 26, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants