[FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module #23932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veSlotPoolBridge test classes of runtime module
|
Hi, @1996fanrui Could you help review this pr if you're in the free time? |
1996fanrui
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Thanks @RocMarshal for the contribution!
I left some minor comments, please take a look in your free time, thanks~
| @@ -45,10 +45,10 @@ | |||
| import static org.assertj.core.api.Assertions.assertThat; | |||
|
|
|||
| @ExtendWith(TestLoggerExtension.class) | |||
There was a problem hiding this comment.
Suggested change
| @ExtendWith(TestLoggerExtension.class) |
TestLoggerExtension has been added in the module level.
|
|
||
| /** Tests how the {@link DeclarativeSlotPoolBridge} completes slot requests. */ | ||
| public class DeclarativeSlotPoolBridgeRequestCompletionTest extends TestLogger { | ||
| @ExtendWith(TestLoggerExtension.class) |
There was a problem hiding this comment.
Suggested change
| @ExtendWith(TestLoggerExtension.class) |
|
|
||
| /** Tests for the {@link DeclarativeSlotPoolBridge}. */ | ||
| @RunWith(Parameterized.class) | ||
| public class DeclarativeSlotPoolBridgeResourceDeclarationTest extends TestLogger { | ||
| @ExtendWith({TestLoggerExtension.class, ParameterizedTestExtension.class}) |
There was a problem hiding this comment.
Suggested change
| @ExtendWith({TestLoggerExtension.class, ParameterizedTestExtension.class}) | |
| @ExtendWith(ParameterizedTestExtension.class) |
| FlinkMatchers.futureWillCompleteExceptionally(Duration.ofMinutes(1))); | ||
|
|
||
| assertThatFuture(allocationFuture).failsWithin(Duration.ofMinutes(1)); | ||
| Thread.sleep(5L); |
There was a problem hiding this comment.
Nice catch!
sorry for it. Maybe it's a dirty line from the cp.
I'll remove it and check it on the other corresponding PRs.
|
|
||
| /** Tests for the {@link DeclarativeSlotPoolBridge}. */ | ||
| @RunWith(Parameterized.class) | ||
| public class DeclarativeSlotPoolBridgeTest extends TestLogger { | ||
| @ExtendWith({TestLoggerExtension.class, ParameterizedTestExtension.class}) |
There was a problem hiding this comment.
Suggested change
| @ExtendWith({TestLoggerExtension.class, ParameterizedTestExtension.class}) | |
| @ExtendWith(ParameterizedTestExtension.class) |
1996fanrui
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks @RocMarshal for the update!
LGTM assuming CI is green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-33853][runtime][JUnit5 Migration] Migrate Junit5 for DeclarativeSlotPoolBridge test classes of runtime module
Brief change log
Verifying this change
N.A
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation