[FLINK-33932][checkpointing] Add retry mechanism in RocksDBStateUploader #23986
+49
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowojski
requested changes
Jan 4, 2024
Comment on lines
60
to
62
| private static final int DEFAULT_RETRY_TIMES = 3; | ||
|
|
||
| private static final Duration DEFAULT_RETRY_DELAY = Duration.ofSeconds(1L); |
There was a problem hiding this comment.
This should be configurable and most likely in the first release default to the current behaviour.
| stateScope, | ||
| closeableRegistry, | ||
| tmpResourcesRegistry)), | ||
| () -> { |
There was a problem hiding this comment.
Please extract to separate method.
Comment on lines
153
to
156
| TimeUnit.MILLISECONDS.sleep( | ||
| retryStrategy | ||
| .getRetryDelay() | ||
| .toMillis()); |
There was a problem hiding this comment.
It would be better to not synchronously wait on the timeout, and free up the thread pool to do other things.
|
Sorry for jumping in but may I ask about the current status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add retry mechanism in RocksDBStateUploader
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation