Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33947][configuration] Fix bugs about the prefix attribute in the DelegatingConfiguration class. #24001

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

[FLINK-33947][configuration] Fix bugs about the prefix attribute in the DelegatingConfiguration class.

It was resulted from #23994 (comment)

  • Check and confirm other potential bug points

  • Fix the bugs about prefix key mapping when operating.

Brief change log

  • Marked prefix as @Nonnull and adapted assignment about prefix
  • Fixed bug about methods removeKey & removeConfig

Verifying this change

  • DelegatingConfigurationTest#testRemoveKeyOrConfig

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 27, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RocMarshal for the fix!

LGTM.

@1996fanrui 1996fanrui marked this pull request as ready for review December 29, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants