Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API #24080

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

pvary
Copy link
Contributor

@pvary pvary commented Jan 12, 2024

What is the purpose of the change

Add new SinkV2 API interfaces, set inheritance and deprecation for the old interfaces.

Added fix for the concurrent commit

Brief change log

All the new API's defined in FLIP-372

One minor additional change:

  • Added map to CommittableSummary and CommittableWithLineage so it will be easier to map when the types are changed.

Verifying this change

The existing tests should run without issue, to verify the backward compatibility.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 12, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@pvary
Copy link
Contributor Author

pvary commented Jan 16, 2024

@gyfora: Please merge. We have a green test run. Thx

@gyfora gyfora merged commit 40cbf23 into apache:master Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants