Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34029][runtime-web] Support different profiling mode on Flink WEB #24130

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

yuchen-ecnu
Copy link
Contributor

What is the purpose of the change

This is a subtask of FLIP-375, which introduces the different profiling modes on the Flink Web for profiling Taskmanager & Jobmanager.

Brief change log

(for example:)

  • Provide profiling mode selector and hint on Flink Web

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented, it will be added in [FLINK-33436]

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 18, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@yuchen-ecnu
Copy link
Contributor Author

Hi @Myasuka , do you have time to help review this PR.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. I think we can also provide links to the different modes in the descriptions.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@Myasuka Myasuka merged commit 4db6e72 into apache:master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants