Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] peekNextBufferSubpartitionId shouldn't throw UnsupportedDataTypeException #24147

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[hotfix] peekNextBufferSubpartitionId shouldn't throw UnsupportedDataTypeException #24147

merged 1 commit into from
Jan 19, 2024

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Jan 19, 2024 •
edited

We shouldn't throw this UnsupportedDataTypeException here. If we really want, can also use generic IOException or UnsupportedOperationException instead.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 19, 2024 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa changed the title [hotfix] TestingTierConsumerAgent#peekNextBufferSubpartitionId shouldn't throw UnsupportedDataTypeException [hotfix] peekNextBufferSubpartitionId shouldn't throw UnsupportedDataTypeException Jan 19, 2024
@snuyanzin snuyanzin mentioned this pull request Jan 19, 2024
Closed
@yunfengzhou-hub
Copy link
Contributor

Thanks for the PR @reswqa. LGTM.

@dawidwys dawidwys merged commit 8dd28a2 into apache:master Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunfengzhou-hub yunfengzhou-hub yunfengzhou-hub approved these changes

@charlesy6 charlesy6 charlesy6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@reswqa @flinkbot @yunfengzhou-hub @charlesy6 @dawidwys