Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][table] Avoid KeyedLookupJoinWrapper sending duplicate delete record for left join when state expired #24164

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

lincoln-lil
Copy link
Contributor

What is the purpose of the change

This is a hotfix for FLINK-34166 (which fixes KeyedLookupJoinWrapper not sending incorrect delete message for inner join when previous lookup result is empty), it cause duplicate delete message for a left join when state expired(lack of ttl expiration case before), this pr fix the state stale logic and add corresponding tests.

Brief change log

  • reserve single pad null logic for left join when process retract message
  • update related tests

Verifying this change

  • KeyedLookupJoinHarnessTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@lincoln-lil lincoln-lil changed the title [hotfix][table] Avoid sending duplicate delete record for left join when state expired [hotfix][table] Avoid KeyedLookupJoinWrapper sending duplicate delete record for left join when state expired Jan 22, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 22, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lincoln-lil Thanks for the pr. LGTM

@lincoln-lil lincoln-lil merged commit b79d3f0 into apache:master Jan 22, 2024
@lincoln-lil lincoln-lil deleted the hotfix-FLINK-34166 branch January 22, 2024 12:33
@lincoln-lil lincoln-lil restored the hotfix-FLINK-34166 branch January 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants