Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34199] Add tracing for durations of rescaling/restoring RocksDB incremental checkpoints from downloaded and local state #24168

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

StefanRRichter
Copy link
Contributor

What is the purpose of the change

This PR extends #24031 with traces for the rescaling/restore times from local state.

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 22, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the purpose this PR:

  • from the title and docs, it seems to be to measure the restore time for local state
  • but the implementation measures restore time for all state

Or am I missing something?

Regardless, I think the latter (measure restore times) makes sense.
Besides of that, measuring remote and/or local state size would be more useful than restore time from local state.

WDYT?

@StefanRRichter
Copy link
Contributor Author

I think the description is correct, depending on you point of view. Recovery today has two phases:

  1. If there is any remote state it will be downloaded and becomes local state.
  2. Then we either rescale or reopen the DB from local state.

And the PR is about measuring the 2nd phase (after we have already duration for the first).

@StefanRRichter
Copy link
Contributor Author

Besides that, I already merged a PR that measures local/remote state sizes. And in our meeting we found that all of the metrics are useful :)

@StefanRRichter StefanRRichter force-pushed the srichter-FLINK-34199-rescale-duration-trace branch from ab7a654 to 268439e Compare January 23, 2024 09:45
@rkhachatryan
Copy link
Contributor

Right 😅
Then I guess the only confusion for me is about "local" in names and docs: remote state that is downloaded can be called "local", but it's pure implementation detail. It can't be used for local recovery yet; so it's not local from the user point of view.

@StefanRRichter
Copy link
Contributor Author

I wrote the docs slightly different, hope that makes it clearer.

@StefanRRichter StefanRRichter changed the title [FLINK-34199] Add tracing for durations of rescaling/restoring from local state [FLINK-34199] Add tracing for durations of rescaling/restoring RocksDB incremental checkpoints from downloaded and local state Jan 23, 2024
Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@StefanRRichter StefanRRichter force-pushed the srichter-FLINK-34199-rescale-duration-trace branch from a15b23c to c72b27d Compare January 24, 2024 17:10
@StefanRRichter StefanRRichter force-pushed the srichter-FLINK-34199-rescale-duration-trace branch from c72b27d to bc5b4a1 Compare February 12, 2024 14:48
@StefanRRichter StefanRRichter marked this pull request as ready for review February 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants