Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig #24187

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

reswqa
Copy link
Member

@reswqa reswqa commented Jan 24, 2024

What is the purpose of the change

Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig

Brief change log

  • Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig
  • Deprecate createSeriazlier(ExecutionConfig) in favor of createSeriazlier(SerializerConfig)

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 24, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa reswqa changed the title [WIP][FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig to SerializerConfig [WIP][FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig Jan 24, 2024
@reswqa reswqa changed the title [WIP][FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig [FLINK-34204][core] Dispatch legacy serializer related methods in ExecutionConfig and TypeInformation to SerializerConfig Jan 25, 2024
@reswqa reswqa marked this pull request as ready for review January 25, 2024 11:55
tools/ci/test_controller.sh Outdated Show resolved Hide resolved
@reswqa
Copy link
Member Author

reswqa commented Jan 26, 2024

@X-czh Thanks for the review! I have removed the unused option in test_controller.sh and squashed all commits.

@reswqa
Copy link
Member Author

reswqa commented Jan 26, 2024

Thanks for the review. Merging....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants