Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33549][table-runtime] Enable BatchMultipleInputStreamOperatorFactory to support YieldingOperatorFactory interface #24259

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xishuaidelin
Copy link
Contributor

@xishuaidelin xishuaidelin commented Feb 4, 2024

…support YieldingOperatorFactory interface

What is the purpose of the change

This pull request makes BatchMultipleInputStreamOperatorFactory to support YieldingOperatorFactory interface.

Brief change log

make class BatchMultipleInputStreamOperatorFactory implement YieldingOperatorFactory interface.

Verifying this change

N/A

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 4, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xishuaidelin xishuaidelin changed the title [FLINK-33549][streaming-api] Enable AbstractStreamOperatorFactory to support YieldingOperatorFactory interface [FLINK-33549][streaming-api] Enable BatchMultipleInputStreamOperatorFactory to support YieldingOperatorFactory interface Feb 4, 2024
@xishuaidelin xishuaidelin changed the title [FLINK-33549][streaming-api] Enable BatchMultipleInputStreamOperatorFactory to support YieldingOperatorFactory interface [FLINK-33549][table-runtime] Enable BatchMultipleInputStreamOperatorFactory to support YieldingOperatorFactory interface Feb 4, 2024
Copy link
Contributor

@xuyangzhong xuyangzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. I left some comments. BTW, can you fix the compile error?

public class BatchMultipleInputStreamOperatorFactory
extends AbstractStreamOperatorFactory<RowData> {
public class BatchMultipleInputStreamOperatorFactory extends AbstractStreamOperatorFactory<RowData>
implements YieldingOperatorFactory<RowData> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little curious, why no tests are added for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants