Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34371][runtime] Support EndOfStreamTrigger and isOutputOnlyAfterEndOfStream operator attribute to optimize task deployment #24272

Closed
wants to merge 10 commits into from
Closed

[FLINK-34371][runtime] Support EndOfStreamTrigger and isOutputOnlyAfterEndOfStream operator attribute to optimize task deployment #24272

wants to merge 10 commits into from

Conversation

yunfengzhou-hub
Copy link
Contributor

What is the purpose of the change

This pull request adds support for EndOfStreamTrigger and isOutputOnlyAfterEndOfStream operator attribute to optimize task deployment.

Brief change log

  • Introduces OperatorAttributes with isOutputOnlyAfterEndOfStream attribute
  • Schedules operators with isOutputOnlyAfterEndOfStream=true to run in blocking mode
  • Make WindowOperator and StreamSortOperator return isOutputOnlyAfterEndOfStream=true in certain cases

Verifying this change

  • This change adds unit tests for OperatorAttributes and the corresponding blocking mode changes.
  • The change on WindowOperator and StreamSortOperator is covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): yes
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 6, 2024 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sxnan
Sxnan reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@Sxnan Sxnan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunfengzhou-hub Thanks for the PR! Just left some comments below.

...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java Outdated Show resolved Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java Outdated Show resolved Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java Outdated Show resolved Hide resolved
...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java Outdated Show resolved Hide resolved
...ing-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/GlobalWindows.java Outdated Show resolved Hide resolved
@yunfengzhou-hub
Copy link
Contributor Author

Thanks for the comments @Sxnan @mohitjain2504 . I have updated the PR according to the comments.

@Sxnan
Copy link
Contributor

Sxnan commented Feb 21, 2024

@yunfengzhou-hub Thanks for the update. LGTM!

WencongLiu
WencongLiu reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@WencongLiu WencongLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments. PTAL. 😄

...-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java Show resolved Hide resolved
...in/java/org/apache/flink/streaming/runtime/translators/OneInputTransformationTranslator.java Show resolved Hide resolved
xintongsong
xintongsong approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohitjain2504
Copy link

What is the reason for closing? Did I miss something?

@xintongsong
Copy link
Contributor

@mohitjain2504
It's merged.

hanyuzheng7 pushed a commit to hanyuzheng7/flink that referenced this pull request May 6, 2024
@Sxnan @hanyuzheng7
[FLINK-34371][runtime] Set OutputOnlyAfterEndOfStream on WindowOperat…
a0ef2c3 
…or and StreamSortOperator

This closes apache#24272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sxnan Sxnan Sxnan left review comments

@mohitjain2504 mohitjain2504 mohitjain2504 left review comments

@WencongLiu WencongLiu WencongLiu left review comments

@xintongsong xintongsong xintongsong approved these changes

Assignees
No one assigned
Labels
component=Runtime/Checkpointing component=Runtime/Task
Projects
None yet
Milestone
No milestone
6 participants
@yunfengzhou-hub @flinkbot @Sxnan @mohitjain2504 @xintongsong @WencongLiu