-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34386][state] Add RocksDB bloom filter metrics #24274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you forgot to regenerate the docs, hence the test failure. Could you fix that?
@flinkbot run azure |
7cc4dcb
to
b9345a7
Compare
@flinkbot run azure |
@flinkbot run azure |
There are some issue while building the hadoop image: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57409&view=logs&j=ef799394-2d67-5ff4-b2e5-410b80c9c0af&t=9e5768bc-daae-5f5f-1861-e58617922c7a&l=10543
|
@hejufang the issue should be fixed if you rebase your branch |
0948c38
to
3b193ff
Compare
@flinkbot run azure |
@JingGe Thank you for your advice. The issue is fixed. |
@pnowojski kindly remind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks good.
.booleanType() | ||
.defaultValue(false) | ||
.withDescription( | ||
"Monitor the total count of bloom FullFilter has not avoided the reads and data actually exist."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a refine, such as "Monitor the count of reads avoided by full filter while the data actually exists in RocksDB".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your advice, I’ve refined this description.
3b193ff
to
66a089f
Compare
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the update.
What is the purpose of the change
Add RocksDB bloom filter metrics.
Brief change log
Get RocksDB bloom filter metrics via RocksDB Statistics, and report it via Metrics reporter.
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation