-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL #24290
base: master
Are you sure you want to change the base?
Conversation
096179d
to
e8dbf8f
Compare
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hackergin thanks for the PR. I had a few comments.
...rc/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala
Outdated
Show resolved
Hide resolved
@xuyangzhong @fsk119 Please help review when you have time, thank you. @jeyhunkarimov Do you have any other suggestions for this PR? |
@flinkbot run azure |
…gation with Set TTL
e8dbf8f
to
05a066e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contributions. I just left some minor comments :)
...rc/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala
Outdated
Show resolved
Hide resolved
...rc/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala
Show resolved
Hide resolved
@xuyangzhong Thank you for the valuable suggestion. Following your advice, I have added relevant unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this updating :D
What is the purpose of the change
Outputting Identical Results in Mini-Batch Aggregation with Set TTL
Brief change log
MiniBatchGlobalGroupAggFunction
andMiniBatchGroupAggFunction
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation