Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL #24290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hackergin
Copy link
Contributor

What is the purpose of the change

Outputting Identical Results in Mini-Batch Aggregation with Set TTL

Brief change log

  • Outputting Identical Results in Mini-Batch Aggregation with Set TTL including MiniBatchGlobalGroupAggFunction and MiniBatchGroupAggFunction

Verifying this change

This change added tests and can be verified as follows:

  • Extended unit test case in GroupAggregateHarnessTest#testAggregateWithRetraction that the aggregation results are the last result.
  • Add the unit test GroupAggregateHarnessTest#testGlobalAggregateWithRetraction including MiniBatchGlobalGroupAggFunction

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 8, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hackergin
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@jeyhunkarimov jeyhunkarimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hackergin thanks for the PR. I had a few comments.

@hackergin
Copy link
Contributor Author

@xuyangzhong @fsk119 Please help review when you have time, thank you.

@jeyhunkarimov Do you have any other suggestions for this PR?

@hackergin
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@xuyangzhong xuyangzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contributions. I just left some minor comments :)

@hackergin
Copy link
Contributor Author

@xuyangzhong Thank you for the valuable suggestion. Following your advice, I have added relevant unit tests.

Copy link
Contributor

@xuyangzhong xuyangzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this updating :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants