Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34437][SQL Client] Fix typo #24310

Merged
merged 1 commit into from Feb 20, 2024
Merged

[FLINK-34437][SQL Client] Fix typo #24310

merged 1 commit into from Feb 20, 2024

Conversation

rmoff
Copy link
Contributor

@rmoff rmoff commented Feb 13, 2024

What is the purpose of the change

The SQL Client issues a message when a statement successfully executes. For example:

Flink SQL> CREATE CATALOG c_new WITH ('type'='generic_in_memory');
[INFO] Execute statement succeed.

The use of succeed is incorrect, and should read succeeded. This PR fixes this.

Brief change log

  • Changed the actual message
  • Changed the tests and docs that reference it.

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

-> This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 13, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@rmoff rmoff marked this pull request as ready for review February 13, 2024 16:04
@JingGe
Copy link
Contributor

JingGe commented Feb 15, 2024

@rmoff Thanks for your contribution! Would you please squash your commits into one?

Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
will be merged after commits have been squashed

Fix tests that reference the message

Fix text in docs

Fix tests that reference the message
@rmoff
Copy link
Contributor Author

rmoff commented Feb 15, 2024

squashed, thanks @JingGe !

Copy link
Contributor

@JingGe JingGe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JingGe JingGe merged commit 4f28512 into apache:master Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants