Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20090][rest] Expose slot sharing group info in REST API #24380

Merged
merged 1 commit into from Feb 29, 2024

Conversation

gaborgsomogyi
Copy link
Contributor

What is the purpose of the change

At the moment slot sharing group information is not exposed in the REST API. In this PR I've added it.
This feature can be used for example in the operator to introduce resource quotas.

Brief change log

Exposed slot sharing group information in the REST API.

Verifying this change

Manually.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not applicable

@gaborgsomogyi
Copy link
Contributor Author

cc @gyfora

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 26, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@gyfora gyfora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any test that shows that the slot info is correctly returned? Maybe I missed it...

@gaborgsomogyi
Copy link
Contributor Author

Valid point, just added.

@gaborgsomogyi gaborgsomogyi merged commit 34a7734 into apache:master Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants