Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34609][table] Migrate BatchPhysicalScriptTransformRule to java. #24457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuyongvs
Copy link
Contributor

What is the purpose of the change

A bit reasoning for the change

The reason is that since 1.28.0 ( CALCITE-4787 - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( CALCITE-4839 - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code.

The PR migrates BatchPhysicalScriptTransformRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it?
Please read jira comment: as I mentioned ConverterRules are not affected and we do not need to migrate them

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 7, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuyongvs
Copy link
Contributor Author

@snuyanzin sorry. i don't have seen your issue desciption.
But i think although the current ConverterRule does not have the issue described, and the current Flink planner module has achieved Scala-free status, I still suggest migrate to Java to maintain consistency in the rules. What do you think?

@liuyongvs liuyongvs requested a review from snuyanzin March 7, 2024 06:19
@snuyanzin
Copy link
Contributor

let''s discuss it in one place
https://issues.apache.org/jira/browse/FLINK-34156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants